This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH, RFC/RFA]: Drop GDB-private regex implementation
- To: Mark Kettenis <kettenis at wins dot uva dot nl>
- Subject: Re: [PATCH, RFC/RFA]: Drop GDB-private regex implementation
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Mon, 20 Aug 2001 01:45:50 -0400
- Cc: gdb-patches at sources dot redhat dot com
- References: <200108190824.f7J8OOg00489@delius.kettenis.local>
> Here's a patch to drop the GDB-private regex implementation
> (gnu-regex.c, gnu-regex.h) in favor of the recently introduced version
> in libiberty. Maintaining two versions of (almost) identical code
> seems a waste of resources to me.
>
> If I don't see any objections in the next two weeks, I'll check this
> in.
Did the POSIX vs BSD(?) regex problem get resolved? I recall being told
that GDB was using BSD but libiberty regex was providing POSIX behavour
(or perhaphs I've got the wrong end of the stick here).
Beyond that, I can't see a reason to not do this.
Andrew
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> Make GDB use libiberty regex implementation.
> * gdb_regex.h: Normalize protection against multiple inclusion.
> Include "xregex.h" instead of "nu-regex.h".
> * Makefile.in (REGEX): Remove.
> (GDB_CFLAGS): Remove reference to gnu-regex.h in comment.
> (ADD_FILES, ADD_DEPS): Remove $(REGEX).
> (POSSLIBS): Remove.
> (TAGFILES_NO_SRCDIR): Remove $(POSSLIBS).
> (irix5-nat.o, solib.o, solib-svr4.o, source.o, symtab.o,
> xcoffsolib.o, cli-decode.o, cli-cmd.o): Replace gnu-regex.h with
> gdb_regex.h in list of dependencies.
> (gnu-regex.o): Remove rule.
> (gnu-regex.c, gnu-regex.h): Remove files.
>
>