This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Multiarch tm_print_insn
- To: Elena Zannoni <ezannoni at cygnus dot com>
- Subject: Re: [RFA] Multiarch tm_print_insn
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Date: Wed, 5 Sep 2001 13:13:12 +0300 (IDT)
- cc: ezannoni at cygnus dot com, gdb-patches at sources dot redhat dot com
On Wed, 5 Sep 2001, Elena Zannoni wrote:
> How about this?
Approved, with a few minor comments (see below).
Thanks!
> +debugged memory abd returns the length of the instruction, in bytes. If
^^^
A typo.
> +a target doesn't define its own printing routine, it defaults to an
> +accessor function for the global pointer @var{tm_print_insn}.
Isn't tm_print_insn a name of a real variable in GDB sources? If so,
it should have the @code markup; @var is for names of formal
parameters and such likes: names that stand for something else, not
for themselves.
> +usually points to a function in the @code{opcodes} library
> +(@xref{,,opcodes}).
Does opcodes have a manual? I cannot find it anywhere. If there is
no docs for opcodes, I think we should remove the xref.
> @var{info} is a structure defined in @code{opcodes}
> +used to pass information to the instruction decoding routine.
Maybe we should at least tell what is the name of that structure, so
that an interested reader could grep for it in opcodes' sources.