This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: "show user" output
- To: Jackie Smith Cashion <jsmith at redhat dot com>
- Subject: Re: RFA: "show user" output
- From: Fernando Nasser <fnasser at redhat dot com>
- Date: Fri, 07 Sep 2001 10:05:47 -0400
- CC: GDB Patches <gdb-patches at sources dot redhat dot com>
- Organization: Red Hat Canada
- References: <3B97F051.7D3E36C2@redhat.com>
Jackie Smith Cashion wrote:
>
> I recently noticed that the "show user" output is messed up. The "if",
> "else", "while", and "end" keywords are printed twice on the line. I
> have attached a patch that fixes this.
>
Have you checked the MI output before and after your patch?
In particular, this bit suggests that in this last chunk you've removed
the
"good" else/end and left the "bad" ones ;-)
> *************** print_command_lines (struct ui_out *uiou
> *** 197,208 ****
> {
> if (depth)
> ui_out_spaces (uiout, 2 * depth);
> - ui_out_field_string (uiout, NULL, "else");
> ui_out_text (uiout, "else\n");
> print_command_lines (uiout, list->body_list[1], depth + 1);
> }
>
> - ui_out_field_string (uiout, NULL, "end");
> if (depth)
> ui_out_spaces (uiout, 2 * depth);
> ui_out_text (uiout, "end\n");
> --- 194,203 ----
Regards,
Fernando
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9