This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Fear and loathing in lookup_block_symbol
- To: Jason Molenda <jmolenda at apple dot com>
- Subject: Re: Fear and loathing in lookup_block_symbol
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Fri, 14 Sep 2001 10:39:56 -0400
- Cc: gdb-patches at sources dot redhat dot com
- References: <B849B437-A2F6-11D5-B65F-000393540DDC@apple.com>
> We can't copy the old code's style exactly. SYMBOL_MATCHES_NAME calls strcmp_iw() on the demangled names (to ignore whitespace), but strcmp_iw is poorly named; it doesn't give you a less-than greater-than return value like strcmp(). It'd be better termed streq_iw() or something unlike strcmp(). But we can make vast improvements without digging into this problem by changing the code to something like:
I'd consider a change to fix strcmp_iw() semantics so that it more
correctlu resembles strcmp(), to be an obvious fix.
as for streq(), we're trying to kill off those STREQ() macro's so this
could confuse things :-)
andrew