This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [5.1/rfc] Don't print ``(MI_OUT)'' during startup


> Andrew Cagney wrote:
> 
>> 
>> Hello,
>> 
>> Given MI is enabled by default, I don't think it makes much sense to
>> print ``<version> (MI_OUT)''.  The attached eliminates that output
>> and updates the testsuite to match.
>> 
>> Thoughts, if there are no objections, I'll commit it to the 5.1 branch.
>> 
>> enjoy,
>> Andrew
>> 
> 
> 
> What if someone disables the MI?  
> How will you prevent the gdb.mi tests to run?

Not supported? ;-)  More seriously, the change:


>> Index: testsuite/lib/mi-support.exp
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v
>> retrieving revision 1.8
>> diff -p -r1.8 mi-support.exp
>> *** mi-support.exp      2001/06/27 17:27:08     1.8
>> --- mi-support.exp      2001/10/21 01:19:19
>> *************** proc mi_gdb_start { } {
>> *** 117,129 ****
>> return 1;
>> }
>> gdb_expect {
>> -       -re ".*MI_OUT.*$mi_gdb_prompt$" {
>> -           verbose "GDB initialized."
>> -       }
>> -re ".*$mi_gdb_prompt$" {
>> !           untested "Skip mi tests (output not in headless format)."
>> !           remote_close host;
>> !           return -1;
>> }
>> -re ".*$gdb_prompt $" {
>> untested "Skip mi tests (got non-mi prompt)."
>> --- 117,124 ----
>> return 1;
>> }
>> gdb_expect {
>> -re ".*$mi_gdb_prompt$" {
>> !           verbose "GDB initialized."
>> }
>> -re ".*$gdb_prompt $" {
>> untested "Skip mi tests (got non-mi prompt)."

should handle this.  The old test was kind of bogus - it went to all the 
effort of exactly matching an MI prompt - vis ``(gdb) \r\n'' - and then 
declare that that the MI didn't get enabled!  Also if the MI isn't 
linked in, GDB will report that the interpreter ``mi'' is unknown.

enjoy,
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]