This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: --args


Tom Tromey writes:
 > >>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
 > 
 > Tom> +f::CONSTRUCT_INFERIOR_ARGUMENTS:char *:construct_inferior_arguments:int argc, char **argv:argc, argv:::construct_inferior_arguments::0
 > 
 > Andrew> Could you please tweek this to be:
 > Andrew> 	m:::char *:....
 > Andrew> instead of ``f:''.
 > 
 > Done.
 > It wasn't clear to me when I would use `f' or `m', so I picked
 > arbitrarily.
 > 
 > >> +      n = CONSTRUCT_INFERIOR_ARGUMENTS (inferior_argc, inferior_argv);
 > 
 > Andrew> the above will also need to be tweeked to be:
 > Andrew> 	n = gdbarch_construct_inferior_arguments (current_gdbarch, ...);
 > 
 > Also done.
 > Thanks.
 > 
 > Andrew> Just check with Fernando and Elena.
 > 
 > Ok.

main.c changes are ok.

Elena


 > 
 > Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]