This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] mips argument passing fixes for o32
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 27 Nov 2001 10:48:16 -0500
- Subject: Re: [rfa] mips argument passing fixes for o32
- References: <20010706112635.A5870@nevyn.them.org> <3B4D5E95.6010407@cygnus.com> <20010712103946.C6359@nevyn.them.org> <3B4DF3A9.8010205@cygnus.com> <3B58AEBE.1000304@cygnus.com>
On Fri, Jul 20, 2001 at 06:20:46PM -0400, Andrew Cagney wrote:
> Daniel,
>
> Just to close this current thread. For the moment I'm rejecting the change:
>
> >if (!MIPS_EABI
> > && MIPS_SAVED_REGSIZE < 8
> >- && TARGET_BYTE_ORDER == BIG_ENDIAN
> >+ && (TARGET_BYTE_ORDER == BIG_ENDIAN
> >+ || TYPE_LENGTH (arg_type) < MIPS_SAVED_REGSIZE)
> > && partial_len < MIPS_SAVED_REGSIZE
> > && (typecode == TYPE_CODE_STRUCT ||
> > typecode == TYPE_CODE_UNION))
>
> I need hard evidence (not comments from GCC) that LE o32 does indead
> left shift small register structs. I'll probably eventually get that
> evidence however, until then I'd prefer to drop this change.
Meanwhile, to really close the current thread, I have adequately
convinced myself and the current MIPS GCC maintainer that GCC is in
error. Hopefully be fixed soon in the dev snapshots, after he tests my
patch a little more.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer