This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Define SVR4 link map offset fetcher for Linux/PPC
- From: Elena Zannoni <ezannoni at cygnus dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: Kevin Buettner <kevinb at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Mon, 3 Dec 2001 00:38:18 -0500
- Subject: Re: [PATCH] Define SVR4 link map offset fetcher for Linux/PPC
- References: <1011201003404.ZM23547@ocotillo.lan><3C0A6CB3.9080104@cygnus.com>
Andrew Cagney writes:
> > I've tested this patch on AIX (to make sure I didn't break the build
> > or cause any regressions) and also in a Linux/x86 cross Linux/PPC test
> > environment.
>
> Kevin, did you try this with --target=powerpc-eabi as listed in the
> MAINTAINERS? I'm seeing a -Werror of solib_add() undefined:
>
> > /home/scratch/PENDING/rm-obsolete/src/gdb/solib-svr4.c:912: warning: implicit declaration of function `solib_add'
> > gmake[1]: *** [solib-svr4.o] Error 1
> > gmake[1]: Leaving directory `/home/scratch/PENDING/rm-obsolete/carp/X-powerpc-eabi/gdb'
> > gmake: *** [all-gdb] Error 2
>
> enjoy,
> Andrew
>
With powerpc-eabi I am also getting these:
/bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:857: undefined reference to `remove_solib_event_breakpoints'
/bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:984: undefined reference to `create_solib_event_breakpoint'
libgdb.a(solib.o): In function `clear_solib':
/bart/ezannoni/uberbaum/src/gdb/solib.c:732: undefined reference to `disable_breakpoints_in_shlibs'
collect2: ld returned 1 exit status
I guess it is missing the SOLIB_ADD macro definition.
Should an
#include "solib.h" be added to the config/powerpc/*.h files?
That seems to work.
Elena
> > * ppc-linux-tdep.c (solib-svr4.h): Include.
> > (ppc_linux_svr4_fetch_link_map_offsets): New function.
> > * ppc-tdep.h (ppc_linux_svr4_fetch_link_map_offsets): Declare.
> > * rs6000-tdep.c (solib-svr4.h): Include.
> > (rs6000_gdbarch_init): Set up ppc_linux_svr4_fetch_link_map_offsets()
> > as the link map offsets fetcher.
> >
> > * config/powerpc/aix.mt (TDEPFILES): Add solib-svr4.o.
> > * config/powerpc/macos.mt (TDEPFILES): Likewise.
> > * config/powerpc/nbsd.mt (TDEPFILES): Likewise.
> > * config/powerpc/ppc-eabi.mt (TDEPFILES): Likewise.
> > * config/powerpc/ppc-sim.mt (TDEPFILES): Likewise.
> > * config/powerpc/ppcle-eabi.mt (TDEPFILES): Likewise.
> > * config/powerpc/ppcle-sim.mt (TDEPFILES): Likewise.
> > * config/powerpc/vxworks.mt (TDEPFILES): Likewise.
> > * config/rs6000/aix4.mt (TDEPFILES): Likewise.
> > * config/rs6000/rs6000.mt (TDEPFILES): Likewise.
> > * config/rs6000/rs6000lynx.mt (TDEPFILES): Likewise.
> >
>