Re: [PATCH] Define SVR4 link map offset fetcher for Linux/PPC

[Kevin Buettner <kevinb at redhat dot com>]

On Dec 3, 12:38am, Elena Zannoni wrote:

> Andrew Cagney writes:
>  > > I've tested this patch on AIX (to make sure I didn't break the build
>  > > or cause any regressions) and also in a Linux/x86 cross Linux/PPC test
>  > > environment.
>  > 
>  > Kevin, did you try this with --target=powerpc-eabi as listed in the 
>  > MAINTAINERS?  I'm seeing a -Werror of solib_add() undefined:
>  > 
>  > > /home/scratch/PENDING/rm-obsolete/src/gdb/solib-svr4.c:912: warning: implicit declaration of function `solib_add'
>  > > gmake[1]: *** [solib-svr4.o] Error 1
>  > > gmake[1]: Leaving directory `/home/scratch/PENDING/rm-obsolete/carp/X-powerpc-eabi/gdb'
>  > > gmake: *** [all-gdb] Error 2
>  > 
>  > enjoy,
>  > Andrew
>  > 
> 
> 
> With powerpc-eabi I am also getting these:
> 
> /bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:857: undefined reference to `remove_solib_event_breakpoints'
> /bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:984: undefined reference to `create_solib_event_breakpoint'
> libgdb.a(solib.o): In function `clear_solib':
> /bart/ezannoni/uberbaum/src/gdb/solib.c:732: undefined reference to `disable_breakpoints_in_shlibs'
> collect2: ld returned 1 exit status
> 
> I guess it is missing the SOLIB_ADD macro definition.
> Should an 
> #include "solib.h" be added to the config/powerpc/*.h files?

Yeah, I guess so.  I was trying to think of a better way to handle this,
but this seems like the best solution for now.

Ultimately, we'd like to *not* have ``#include "solib.h"'' in *any*
config/*/{tm,nm}-*.h files.  Rather, this include statement should either
be placed directly in defs.h, or even better still, in just those files
which require it.  But to get to the point where we'll be able to do this,
we'll need to convert the other files which implement solib support over
to using the new mechanisms.  The files which need to be converted are
coff-solib.c, irix5-nat.c, pa64solib.c, somsolib.c, and xcoffsolib.c. 
(Thanks to Nick Duffek, osfsolib.c has already been converted.  It
just needs to be marked as obsolete.)

Kevin