This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: port to Sanyo XStormy16 CPU
On Thu, Dec 13, 2001 at 02:44:37PM +0100, Corinna Vinschen wrote:
> On Tue, Dec 11, 2001 at 03:16:19PM -0800, Andrew Cagney wrote:
> > > Corinna
> > >
> > > gdb ChangeLog:
> > >
> > > 2001-12-10 Corinna Vinschen <vinschen@redhat.com>
> > >
> > > * Makefile.in: Add support for xstormy16.
> > > * configure.tgt: Ditto.
> > > * xstormy16-tdep.c: New file.
> > > * config/xstormy16/xstormy16.mt: New file.
> > >
> > > gdb/testsuite ChangeLog:
> >
> >
> > Yes. Your code is fine. The comments are very much appreciated.
> >
> > Just the usual style things: can I suggest making macro's like
> > TYPE_IS_SCALAR functions; can you please put the .c files through
> > gdb/gdb_indent.sh so it matches GDB's indentation style.
>
> I've rearranged the macro TYPE_IS_SCALAR() to be a function called
> xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c.
>
> Thanks for the approval, I've applied everything.
Uh, careful question: Do I have to add myself as XStormy16 maintainer
to the MAINTAINERS file now?
Corinna