This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Added myself as XStormy16 maintainer in MAINTAINERS


> On Mon, Dec 17, 2001 at 11:05:50AM -0500, Andrew Cagney wrote:
> 
>> > As the subject says...  I added myself as the maintainer for
>> > the new Sanyo XStormy16 target under the obvious fix rule.
> 
>> 
>> 
>> Not 100% obvious :-) You beat me to sending out an e-mail about this 
>> (we'd exchanged e-mail about it) :-/.  Can you also add a ``,-Werror'' 
>> to the end of the MAINTAINERS line and an entry/section in the NEWS file.
> 
> 
> I don't understand the need for the -Werror flag, though.


(Strictly speaking ``,-Werror'' :-)

The ``,-Werror'' documents that you target is of good quality since that 
code contains no compiler warnings (using GDB's select list).  (To be 
honest, if someone asked for an example on how to target GDB, I'd 
probably point them at your code.)

This in turn means that it is reasonable for you to expect someone 
making an obvious change (such as an interface change across all 
targets) to, as part of their testing, ensure that your target sill 
compiles without warnings.  On the other hand, the Arm doesn't have this 
requirement since, thanks to third party code, it can't be compiled with 
``-Werror''

For instance, my byte order changes, which are across targets, are being 
checked by me firstly compiling all targets and secondly by confirming 
that all those GDB's start (without an internal error).

does this help?
Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]