This is the mail archive of the
mailing list for the GDB project.
Re: PATCH: S/390: don't try to read zero bytes
Andrew Cagney <email@example.com> writes:
> > 2001-12-20 Jim Blandy <firstname.lastname@example.org>
> > * s390-tdep.c (s390_readinstruction): Don't call
> > info->read_memory_func to read zero bytes. Some targets'
> > xfer_memory functions can't cope with that.
> Jim, which?
> While slightly stupid, the target should be able to handle that.
That was my feeling, as well. xfer_memory, in exec.c, says:
if (len <= 0)
internal_error (__FILE__, __LINE__, "failed internal consistency check");
In my opinion, the test is wrong, the error message is lousy, and it
should be an assert anyway.