This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[RFA] remove unwanted output in breakpoint_re_set_one
- From: Pierre Muller <muller at cerbere dot u-strasbg dot fr>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 14 Jan 2002 12:37:01 +0100
- Subject: [RFA] remove unwanted output in breakpoint_re_set_one
The patch below finally removes the
lot of "Watchpoint XXXX" or "Hardware watchpoint XXX" output that can be seen
both for normal and hardware watchpoints
at each loadnig of a shared library (or each DLL
in win32 target.
This problem was first reported in my first proposal
about win32 hardware watchpoint support for win32 target,
http://sources.redhat.com/ml/gdb-patches/2001-11/msg00537.html
and caused some confusion, as this was first seen as a
problem with my implementation.
But this was a quite general error present for other targets, like i386 linux,
see my post-scriptum in
http://sources.redhat.com/ml/gdb-patches/2001-12/msg00030.html
The call to mention at that location in breakpoint_re_set_one
seems completely unnecessary.
2002-01-14 Pierre Muller <muller@ics.u-strasbg.fr>
* breakpoint.c (breakpoint_re_set_one): Remove call to mention
for watchpoints to avoid unnecessary output
when dynamic libraries are loaded.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.57
diff -u -p -r1.57 breakpoint.c
--- breakpoint.c 2001/11/11 16:39:59 1.57
+++ breakpoint.c 2002/01/14 11:19:54
@@ -7139,8 +7139,6 @@ breakpoint_re_set_one (PTR bint)
xfree (b->cond);
b->cond = parse_exp_1 (&s, (struct block *) 0, 0);
}
- if (b->enable_state == bp_enabled)
- mention (b);
value_free_to_mark (mark);
break;
case bp_catch_catch:
Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99