This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] remove unwanted output in breakpoint_re_set_one


At 14:42 14/01/02 +0200, Eli Zaretskii wrote:
>
>On Mon, 14 Jan 2002, Pierre Muller wrote:
>
>> 2002-01-14  Pierre Muller  <muller@ics.u-strasbg.fr>
>> 
>> 	* breakpoint.c (breakpoint_re_set_one): Remove call to mention
>> 	for watchpoints to avoid unnecessary output 
>> 	when dynamic libraries are loaded.
>
>This, of course, begs the question: why was the call to `mention' in 
>breakpoint_re_set_one in the first place?  Is this function called only 
>when a dynamic library was loaded?  If not, we might be shooting 
>ourselves in the foot.  Even if it is only called when a dynamic library 
>was loaded, the question why the message was put there still remains.

If you look above in the same function you will see that
mention is called for breakpoints, but only if the breakpoint
address changed.

So it should probably be the same here, but
can a shared lib loading change the watched addresses
needed to watch a given expression? 
I suppose that a correct implementation would 
just call mention if the watched address area are changed,
but I have no idea how that can be done, and I am not
enough interested in this to invest time to try to find out
how that could be accomplished.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]