Re: [RFA] gdbtypes.[ch] rs6000-tdep.c--AltiVec regs types

[Elena Zannoni <ezannoni at redhat dot com>]

Elena Zannoni writes:
 > 
 > This patch provides a builtin union type for the AltiVec registers,
 > so that the printing of such regs is a bit more enlightening, like:
 > 
 > 
 > (gdb) p $vr0
 > $2 = {uint128 = 0x00000064000000c80000012c00000190, 
 >       v4sf = {f = {1.40129846e-43, 2.80259693e-43, 4.20389539e-43, 5.60519386e-43}}, 
 >       v4si = {f = {100, 200, 300, 400}}, 
 >       v8hi = {f = {0, 100, 0, 200, 0, 300, 0, 400}}, 
 >       v16qi = {f = "\0\0\0d\0\0\0È\0\0\001,\0\0\001\220"}}
 > (gdb) p $vr0.v4si
 > $3 = {f = {100, 200, 300, 400}}
 > (gdb) p $vr0.v4si.f[2]
 > $4 = 300
 > (gdb) p $vr0.v4si.f[2]=444
 > $5 = 444
 > 
 > 
 > Elena
 > 

Resubmitting, moved type creation code to gdbtypes.c, used xcalloc().

OK?

Elena


2002-01-14  Elena Zannoni  <ezannoni@redhat.com>

	* gdbtypes.h (builtin_type_v16qi, builtin_type_v8hi): Export.
	(builtin_type_powerpc_altivec): Export.
	* gdbtypes.c (builtin_type_v16qi, builtin_type_v8hi): New SIMD
	types.
	(builtin_type_powerpc_altivec): New builtin type for AltiVec
	registers.
	(build_gdbtypes): Initialize builtin_type_v16qi and
	builtin_type_v8hi.
	(build_builtin_type_powerpc_altivec): New function.
 	(_initialize_gdbtypes): Register builtin_type_v16qi and
	builtin_type_v8hi with gdbarch. Create the altivec register
	builtin type structure.
 	* rs6000-tdep.c (rs6000_register_virtual_type): Change type of
	AltiVec register to new builtin type.


Index: gdbtypes.c
===================================================================
RCS file: /cvs/uberbaum/gdb/gdbtypes.c,v
retrieving revision 1.35
diff -u -p -r1.35 gdbtypes.c
--- gdbtypes.c	2001/12/20 03:26:08	1.35
+++ gdbtypes.c	2002/01/14 23:57:04
@@ -73,7 +73,9 @@ struct type *builtin_type_uint128;
 struct type *builtin_type_bool;
 struct type *builtin_type_v4sf;
 struct type *builtin_type_v4si;
+struct type *builtin_type_v16qi;
 struct type *builtin_type_v8qi;
+struct type *builtin_type_v8hi;
 struct type *builtin_type_v4hi;
 struct type *builtin_type_v2si;
 struct type *builtin_type_ieee_single_big;
@@ -92,6 +94,7 @@ struct type *builtin_type_ia64_spill_big
 struct type *builtin_type_ia64_spill_little;
 struct type *builtin_type_ia64_quad_big;
 struct type *builtin_type_ia64_quad_little;
+struct type *builtin_type_powerpc_altivec;
 struct type *builtin_type_void_data_ptr;
 struct type *builtin_type_void_func_ptr;
 struct type *builtin_type_CORE_ADDR;
@@ -785,7 +788,51 @@ init_simd_type (char *name,
   return t;
 }
 
+static struct type *
+build_builtin_type_powerpc_altivec (void)
+{
+  /* Construct a type for the AltiVec registers.  The type we're building
+     is this: */
+#if 0
+  union __gdb_builtin_type_powerpc_altivec
+  {
+    struct __builtin_v16qi v16qi;
+    struct __builtin_v8hi v8hi;
+    struct __builtin_v4si v4si;
+    struct __builtin_v4sf v4sf;
+    uint128_t uint128;
+  };
+#endif
+
+  struct type *t;
+  struct field *f;
+
+  f = (struct field *) xcalloc (5, sizeof (*f));
+
+  FIELD_TYPE (f[0]) = builtin_type_int128;
+  FIELD_NAME (f[0]) = "uint128";
 
+  FIELD_TYPE (f[1]) = builtin_type_v4sf;
+  FIELD_NAME (f[1]) = "v4sf";
+
+  FIELD_TYPE (f[2]) = builtin_type_v4si;
+  FIELD_NAME (f[2]) = "v4si";
+
+  FIELD_TYPE (f[3]) = builtin_type_v8hi;
+  FIELD_NAME (f[3]) = "v8hi";
+
+  FIELD_TYPE (f[4]) = builtin_type_v16qi;
+  FIELD_NAME (f[4]) = "v16qi";
+
+  /* Build a union type with those fields.  */
+  t = init_type (TYPE_CODE_UNION, 16, 0, 0, 0);
+  TYPE_NFIELDS (t) = 5;
+  TYPE_FIELDS (t) = f;
+  TYPE_TAG_NAME (t) = "__gdb_builtin_type_powerpc_altivec";
+
+  return t;
+}
+
 /* Smash TYPE to be a type of members of DOMAIN with type TO_TYPE. 
    A MEMBER is a wierd thing -- it amounts to a typed offset into
    a struct, e.g. "an int at offset 8".  A MEMBER TYPE doesn't
@@ -3163,8 +3210,12 @@ build_gdbtypes (void)
     = init_simd_type ("__builtin_v4sf", builtin_type_float, "f", 4);
   builtin_type_v4si
     = init_simd_type ("__builtin_v4si", builtin_type_int32, "f", 4);
+  builtin_type_v16qi
+    = init_simd_type ("__builtin_v16qi", builtin_type_int8, "f", 16);
   builtin_type_v8qi
     = init_simd_type ("__builtin_v8qi", builtin_type_int8, "f", 8);
+  builtin_type_v8hi
+    = init_simd_type ("__builtin_v8hi", builtin_type_int16, "f", 8);
   builtin_type_v4hi
     = init_simd_type ("__builtin_v4hi", builtin_type_int16, "f", 4);
   builtin_type_v2si
@@ -3252,7 +3303,9 @@ _initialize_gdbtypes (void)
   register_gdbarch_swap (&builtin_type_uint128, sizeof (struct type *), NULL);
   register_gdbarch_swap (&builtin_type_v4sf, sizeof (struct type *), NULL);
   register_gdbarch_swap (&builtin_type_v4si, sizeof (struct type *), NULL);
+  register_gdbarch_swap (&builtin_type_v16qi, sizeof (struct type *), NULL);
   register_gdbarch_swap (&builtin_type_v8qi, sizeof (struct type *), NULL);
+  register_gdbarch_swap (&builtin_type_v8hi, sizeof (struct type *), NULL);
   register_gdbarch_swap (&builtin_type_v4hi, sizeof (struct type *), NULL);
   register_gdbarch_swap (&builtin_type_v2si, sizeof (struct type *), NULL);
   REGISTER_GDBARCH_SWAP (builtin_type_void_data_ptr);
@@ -3313,6 +3366,9 @@ _initialize_gdbtypes (void)
   builtin_type_ia64_quad_little =
     init_type (TYPE_CODE_FLT, floatformat_ia64_quad_little.totalsize / 8,
 	       0, "builtin_type_ia64_quad_little", NULL);
+
+  builtin_type_powerpc_altivec
+    = build_builtin_type_powerpc_altivec ();
 
   add_show_from_set (
 		     add_set_cmd ("overload", no_class, var_zinteger, (char *) &overload_debug,
Index: gdbtypes.h
===================================================================
RCS file: /cvs/uberbaum/gdb/gdbtypes.h,v
retrieving revision 1.21
diff -u -p -r1.21 gdbtypes.h
--- gdbtypes.h	2001/12/10 06:17:01	1.21
+++ gdbtypes.h	2002/01/14 23:57:09
@@ -946,9 +946,14 @@ extern struct type *builtin_type_uint128
 /* SIMD types.  We inherit these names from GCC.  */
 extern struct type *builtin_type_v4sf;
 extern struct type *builtin_type_v4si;
+extern struct type *builtin_type_v16qi;
 extern struct type *builtin_type_v8qi;
+extern struct type *builtin_type_v8hi;
 extern struct type *builtin_type_v4hi;
 extern struct type *builtin_type_v2si;
+
+/* Type for AltiVec registers on PowerPC. */
+extern struct type *builtin_type_powerpc_altivec;
 
 /* Explicit floating-point formats.  See "floatformat.h".  */
 extern struct type *builtin_type_ieee_single_big;
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/uberbaum/gdb/rs6000-tdep.c,v
retrieving revision 1.35
diff -u -p -r1.35 rs6000-tdep.c
--- rs6000-tdep.c	2002/01/06 04:50:56	1.35
+++ rs6000-tdep.c	2002/01/14 23:57:11
@@ -1550,7 +1550,7 @@ rs6000_register_virtual_type (int n)
 	  return builtin_type_int64;
 	  break;
 	case 16:
-	  return builtin_type_int128;
+	  return builtin_type_powerpc_altivec;
 	  break;
 	default:
 	  return builtin_type_int32;