This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH to stabsread.c:read_member_functions
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Thu, 17 Jan 2002 10:14:55 -0500
- Subject: Re: PATCH to stabsread.c:read_member_functions
- References: <wvlk7uh819y.fsf@prospero.cambridge.redhat.com>
On Thu, Jan 17, 2002 at 03:06:49PM +0000, Jason Merrill wrote:
> This patch fixes gdb.c++/classes.exp:ptype Static when used with gcc 3.x
> and stabs output. The code in question was never correct, just a likely
> guess; in particular, it got things wrong even with the v2 output for
> Static::ii, where the plain function name ("ii") was the same as the
> mangled form of the argument list (int, int == "ii"). For v3, we don't try
> to do minimal output, so it will always guess wrong.
>
> OK? Should I just remove the bad code rather than comment it out?
>
> 2002-01-17 Jason Merrill <jason@redhat.com>
>
> * stabsread.c (read_member_functions): Never guess that the given
> physname for a static member function is a stub.
>
Not OK, I think. v2 -does- do minimal output, right? We are not
dropping v2 support.
I've been meaning to fix this since I added the test. The proper fix
might be to either:
- know when to expect minimal output. Does v2 ever not do it? What
about other C++ compilers?
- Check if it is a valid mangled name. Will that work - can the
argument list ever be a valid mangled name in its own right?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer