This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Replace some literal consts with enums.
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 31 Jan 2002 20:48:31 -0500
- Subject: Re: [PATCH] Replace some literal consts with enums.
- References: <200202010108.g1118GN31973@reddwarf.cygnus.com>
Cool, I like enums. But the formatting of the enum in the .h file is
non-GNU. Is symfile.c the only place where these are used? Would it
be possible to pull the enum inside symfile.c, if this is the case?
Thanks
Elena
Michael Snyder writes:
>
> 2002-01-31 Michael Snyder <msnyder@redhat.com>
>
> * symfile.h (enum overlay_debugging_state):
> Define enum constant values for overlay mode.
> * symfile.c (overlay_debugging): Use enums instead of literals.
> (overlay_is_mapped, overlay_auto_command,
> overlay_manual_command): Ditto.
>
> Index: symfile.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/symfile.h,v
> retrieving revision 1.11
> diff -p -r1.11 symfile.h
> *** symfile.h 2001/12/07 12:10:15 1.11
> --- symfile.h 2002/02/01 01:10:58
> *************** extern void find_lowest_section (bfd *,
> *** 253,259 ****
> extern bfd *symfile_bfd_open (char *);
>
> /* Utility functions for overlay sections: */
> ! extern int overlay_debugging;
> extern int overlay_cache_invalid;
>
> /* return the "mapped" overlay section containing the PC */
> --- 253,263 ----
> extern bfd *symfile_bfd_open (char *);
>
> /* Utility functions for overlay sections: */
> ! extern enum overlay_debugging_state {
> ! ovly_off,
> ! ovly_on,
> ! ovly_auto
> ! } overlay_debugging;
> extern int overlay_cache_invalid;
>
> /* return the "mapped" overlay section containing the PC */