Re: RFA: Recognize corefile error message as failure

[Jim Blandy <jimb at zwingli dot cygnus dot com>]

Fernando Nasser <fnasser@redhat.com> writes:

> Michael Snyder wrote:
> > 
> > Jim Blandy wrote:
> > >
> > > Index: gdb/2001-12-06  Jim Blandy  <jimb@redhat.com>
> > >
> > >         * gdb.base/corefile.exp: Recognize the message saying that GDB
> > >         can't find the core file's registers as a failure.
> > >
> > > testsuite/gdb.base/corefile.exp
> > > ===================================================================
> > > RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/corefile.exp,v
> > > retrieving revision 1.52
> > > diff -c -r1.52 corefile.exp
> > > *** gdb/testsuite/gdb.base/corefile.exp 2001/07/13 23:56:12     1.52
> > > --- gdb/testsuite/gdb.base/corefile.exp 2001/12/06 16:41:13
> > > ***************
> > > *** 110,115 ****
> > > --- 110,118 ----
> > >   verbose "Timeout is now $timeout seconds" 2
> > >   eval "spawn $GDB -nw $GDBFLAGS -core=$objdir/$subdir/corefile"
> > >   expect {
> > > +     -re "Couldn't find .* registers in core file.*$gdb_prompt $" {
> > > +         fail "args: -core=corefile (couldn't find regs)"
> > > +     }
> > >       -re "Core was generated by .*coremaker.*\r\n\#0  .*\(\).*\r\n$gdb_prompt $" {
> > >         pass "args: -core=corefile"
> > >       }
> > 
> > Nobody got back to you on this?
> > I think it looks like a good thing...
> 
> There was no "testsuite" or ".exp" in the subject, so I missed it.
> Thanks Andrew to let me know it was pending.
> 
> And this one is rather an obvious fix.  
> Jim, please feel free to use your blanket write on these cases.

I did; the change has been in since September.  There's no problem
here.