This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] gdb.threads/linux-dp.exp: adjust to new gcc warning

gcc HEAD has a new warning:

  warning: no return statement in function returning non-void

Unfortunately this breaks code in gdb.threads/linux-dp.c:

  void *
  philosopher (void *data)
    for (;;)

I consider this to be a bug in gcc HEAD, and I've filed PR gcc/5725.

Meanwhile, I would like to change linux-dp.c so that it compiles.
This way we are testing linux thread support, which is more useful
than functioning as a test case for PR gcc/5725.

I tested this patch on target=native host=i686-pc-linux-gnulibc2.2:rh-7.2
with gcc 2.95.3, gcc 3.0.3, gcc 3.0.4-20020215, gcc gcc-3_0-branch, and
gcc HEAD, with both -gdwarf-2 and -gstabs+.


  Jason's message about the new warning:

  My reply in the thread:

  My gcc PR:

Okay to apply?

Michael C


2002-02-18  Michael Chastain  <>

	* gdb.threads/linux-dp.c (philosopher): Add a return statement
	to placate gcc.

Index: gdb/testsuite/gdb.threads/linux-dp.c
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.c,v
retrieving revision
diff -c -3 -p -r1.1.1.1 linux-dp.c
*** linux-dp.c	1999/10/19 02:46:48
--- linux-dp.c	2002/02/18 21:37:54
*************** philosopher (void *data)
*** 153,158 ****
--- 153,160 ----
  	pthread_mutex_unlock (&fork_mutex[(n + 1) % num_philosophers]);
  	random_delay ();
+   return (void *) 0;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]