This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH] gdb.c++/virtfunc.exp: remove obsolete calls to setup_xfail
- From: Michael Elizabeth Chastain <mec at shout dot net>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 20 Feb 2002 17:49:49 -0600
- Subject: [PATCH] gdb.c++/virtfunc.exp: remove obsolete calls to setup_xfail
This patch removes 10 setup_xfail lines from gdb.c++/virtfunc.exp:
if {$gcc_compiled} then { setup_xfail "*-*-*" }
All of these tests pass on all the configurations I test (gcc v2 and
v3 compilers, -gdwarf-2 and -gstabs). So the effect on the test results
is to change PASS->XPASS in 10 places. There are no XFAIL->FAIL changes.
If the tests regress and start failing again, I want to see a FAIL,
not an XFAIL. That is what a test suite is for. (I test with both
experimental gcc's and released gcc's. If an experimental gdb regresses
with a released gcc, then it is definitely worthy of attention on the
gdb side).
Some of the tests are still XFAIL'ing. For these tests, I left the
setup_xfail untouched, but I added comments listing configurations
where the tests fail.
I am committing this immanently.
Michael C
===
2002-02-20 Michael Chastain <mec@shout.net>
* gdb.c++/virtfunc.exp (test_virtual_calls): Remove obsolete calls
to setup_xfail. Document some of the remaining calls.
Index: gdb/testsuite/gdb.c++/virtfunc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/virtfunc.exp,v
retrieving revision 1.8
diff -c -3 -p -r1.8 virtfunc.exp
*** virtfunc.exp 2002/01/20 19:22:13 1.8
--- virtfunc.exp 2002/02/20 23:41:39
*************** proc test_virtual_calls {} {
*** 743,754 ****
return 0
}
- # FIXME: In fall 1998, GCC's virtual function type info was changed,
- # which causes GDB to be unable to resolve these calls. Until the
- # problem is fixed, XFAIL these tests. -sts 1999-08-02
-
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pAe->f()\n"
gdb_expect {
-re ".* = 20$nl$gdb_prompt $" { pass "print pAe->f()" }
--- 743,748 ----
*************** proc test_virtual_calls {} {
*** 770,777 ****
eof { fail "print pAe->f() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pAa->f()\n"
gdb_expect {
-re ".* = 1$nl$gdb_prompt $" { pass "print pAa->f()" }
--- 764,769 ----
*************** proc test_virtual_calls {} {
*** 784,791 ****
eof { fail "print pAa->f() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pDe->vg()\n"
gdb_expect {
-re ".* = 202$nl$gdb_prompt $" { pass "print pDe->vg()" }
--- 776,781 ----
*************** proc test_virtual_calls {} {
*** 798,805 ****
eof { fail "print pDe->vg() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pADe->vg()\n"
gdb_expect {
-re ".* = 202$nl$gdb_prompt $" { pass "print pADe->vg()" }
--- 788,793 ----
*************** proc test_virtual_calls {} {
*** 812,819 ****
eof { fail "print pADe->vg() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pDd->vg()\n"
gdb_expect {
-re ".* = 101$nl$gdb_prompt $" { pass "print pDd->vg()" }
--- 800,805 ----
*************** proc test_virtual_calls {} {
*** 826,833 ****
eof { fail "print pDd->vg() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pEe->vvb()\n"
gdb_expect {
-re ".* = 411$nl$gdb_prompt $" { pass "print pEe->vvb()" }
--- 812,817 ----
*************** proc test_virtual_calls {} {
*** 840,847 ****
eof { fail "print pEe->vvb() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pVB->vvb()\n"
gdb_expect {
-re ".* = 407$nl$gdb_prompt $" { pass "print pVB->vvb()" }
--- 824,829 ----
*************** proc test_virtual_calls {} {
*** 854,859 ****
--- 836,845 ----
eof { fail "print pVB->vvb() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gdwarf-2.
+ # -- chastain 2002-02-20
+
if {$gcc_compiled} then { setup_xfail "*-*-*" }
send_gdb "print pBe->vvb()\n"
*************** proc test_virtual_calls {} {
*** 868,875 ****
eof { fail "print pBe->vvb() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pDe->vvb()\n"
gdb_expect {
-re ".* = 411$nl$gdb_prompt $" { pass "print pDe->vvb()" }
--- 854,859 ----
*************** proc test_virtual_calls {} {
*** 882,889 ****
eof { fail "print pDe->vvb() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pEe->vd()\n"
gdb_expect {
-re ".* = 282$nl$gdb_prompt $" { pass "print pEe->vd()" }
--- 866,871 ----
*************** proc test_virtual_calls {} {
*** 896,903 ****
eof { fail "print pEe->vd() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
- if {$gcc_compiled} then { setup_xfail "*-*-*" }
-
send_gdb "print pEe->fvb()\n"
gdb_expect {
-re ".* = 311$nl$gdb_prompt $" { pass "print pEe->fvb()" }
--- 878,883 ----
*************** proc test_virtual_calls {} {
*** 909,914 ****
--- 889,926 ----
timeout { fail "print pEe->fvb() (timeout)" }
eof { fail "print pEe->fvb() ($GDB dumped core) (FIXME)" ; gdb_virtfunc_restart; return }
}
+
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gdwarf-2.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gstabs+.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gdwarf-2.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gdwarf-2.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gstabs+.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-gdwarf-2.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-gstabs+.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-gdwarf-2.
+ #
+ # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
+ # gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-gstabs+.
+ #
+ # -- chastain 2002-02-20
if {$gcc_compiled} then { setup_xfail "*-*-*" }