This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] honor new-console and new-group in win32-nat.c

Since the shell patch in win32-nat.c,
the new-group and new-console commands are igonred.

This is due to a small mistake in  child_create_inferior.

The following patch fixed this.
If you use new-console, this patch will also expose
another problem (not fixed here), which is that the
shell is not allowed to exit after exit of the debuggee.

Christopher,  shouldn't you set usesshell to 0
already so that other people trying to use the cygwin native 
from CVS will be able to use it normally until you
fix the other problems relative to shell usage.

2002-02-22  Pierre Muller  <>

	* win32-nat.c (child_create_inferior): Fix create flags setting bug.

$ cvs diff -up win32-nat.c
Index: win32-nat.c
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.55
diff -u -p -r1.55 win32-nat.c
--- win32-nat.c 2002/02/22 01:35:59     1.55
+++ win32-nat.c 2002/02/22 08:42:16
@@ -1478,7 +1478,7 @@ child_create_inferior (char *exec_file,

    if (!useshell || !shell[0])
+      flags |= DEBUG_ONLY_THIS_PROCESS;
        cygwin_conv_to_win32_path (exec_file, real_path);
        toexec = real_path;
@@ -1488,7 +1488,7 @@ child_create_inferior (char *exec_file,
        sprintf (newallargs, " -c 'exec %s %s'", exec_file, allargs);
        allargs = newallargs;
        toexec = shell;
-      flags = DEBUG_PROCESS;
+      flags |= DEBUG_PROCESS;

    args = alloca (strlen (toexec) + strlen (allargs) + 2);

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]