This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Dwarf2 reader -vs- DW_OP_piece

> That makes sense.
> 
> Could you change your patch to detect that pattern, verify that the
> register numbers are consecutive (according to DWARF2_REG_TO_REGNUM),
> return the number of the first register if everything seems right, and
> give a dwarf2_complex_location_expr complaint otherwise?
> 
> This is a bit more work, but it's more correct.

BTW, this assumption is one of the two origins of our good friend (not) 
read_register_bytes().  Sigh.

Andrew
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]