This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] remote debugging patches
Andrew Cagney wrote:
>> The first one is pretty straightforward and just makes use of the last
>> parameter to getpkt().
>
> As far as I can tell, you've just replaced the last parameter of
> getpkt() with a hardwired value - initially a macro but now an enum. Is
> that the intent?
Yes, it was. I explained my reasons for this change more completely in a
reply to Daniel Jacobowitz. I will consider reworking the code for using
'set debug whatever' command as he stated.
> It is called with both 0 and 1. The target_wait() and target_open()
> (?) code waits forever when in synchronous mode.
On a place where I needed it there was a hardwired '0' so I did the
change. Of course I'm not going to fight for this patch. I'll better
rework it.
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* +420 2 9654 5373 * http://www.suse.cz