This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gdb/409: build failures for targets that should build with -Werror


> http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=409
>> 
>> I suspect the real bug is in the gdb_realpath() code.  It should 
>> strongly prefer realpath() over canonicalize_file_name().  The latter is 
>> (as you noticed) GNU centric - I think it comes from the HURD.
>> 
> 
> 
> OK, so how about this patch.  It fixes most of the multi-build failures.
> 
> <date> Richard Earnshaw  <rearnsha@arm.com>
> 
> * utils.c (gdb_realpath): Prefer realpath() over 
> 	canonicalize_file_name().
> 

Yes.

Can you also please add a comment indicating that 
cannonicalize_file_name() allocates its buffer using malloc() (I just 
looked at the glibc source).

Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]