This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFC: Avoid calling XXX_skip_prologue for assembly code
- From: Fernando Nasser <fnasser at redhat dot com>
- To: fnf at redhat dot com
- Cc: jimb at redhat dot com, fnf at ninemoons dot com, gdb-patches at sources dot redhat dot com, Andrew Cagney <cagney at cygnus dot com>, Michael Snyder <msnyder at cygnus dot com>
- Date: Fri, 12 Apr 2002 12:44:41 -0400
- Subject: Re: RFC: Avoid calling XXX_skip_prologue for assembly code
- Organization: Red Hat Canada
- References: <200204121636.g3CGaGk08573@fishpond.ninemoons.com>
Fred Fish wrote:
>
> > I strongly object to this patch unless accompanied by a set/show
> > command. (But I am not the maintainer.)
>
> There seems to be enough issues with this patch that perhaps I should
> just withdraw it. The alternate solution is to fix the skip_prologue
> functions that don't do the right thing with assembly language
> prologues that don't follow normal conventions. The original
> motivation for this patch was an architecture where skip_prologue
> always returned PC+2 regardless of what it found.
>
It should not be too difficult to add a set/show variable.
But if you can't spare the time, and if people agree with this
solution, you could just enter your patch in the bug database
and say it is pending the creation of the switch. Eventually
someone will get at the bug entry and do it.
Regards,
Fernando
P.S.: Note that I agree with the patch, if controlled by a behavior
variable. My objection is just against hardwiring it.
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9