This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA] Make gdb.base/shlib-call.exp work for AIX
- From: Fernando Nasser <fnasser at redhat dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 18 Apr 2002 16:32:11 -0400
- Subject: Re: [PATCH RFA] Make gdb.base/shlib-call.exp work for AIX
- Organization: Red Hat Canada
- References: <1020418201910.ZM8858@localhost.localdomain>
Kevin Buettner wrote:
>
> The patch below makes some adjustments to gdb.base/shlib-call.exp so
> that it will work for AIX.
>
> Okay to commit?
>
Yes, but please simplify the second chunk by making it a single if
statement.
(Please post the committed patch.)
Thanks for the fix.
Regards,
Fernando
> * gdb.base/shlib-call.exp (additional_flags): AIX doesn't need
> ``-fpic'' when compiling files comprising a shared library, but
> it does need additional linker flags in order to find shared
> libraries at run time.
>
> Index: gdb.base/shlib-call.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shlib-call.exp,v
> retrieving revision 1.4
> diff -u -p -r1.4 shlib-call.exp
> --- gdb.base/shlib-call.exp 14 Feb 2002 06:25:18 -0000 1.4
> +++ gdb.base/shlib-call.exp 18 Apr 2002 20:02:29 -0000
> @@ -70,7 +70,12 @@ if {$gcc_compiled == 0} {
> set additional_flags ""
> }
> } else {
> - set additional_flags "additional_flags=-fpic"
> + if { ([istarget "powerpc*-*-aix*"]
> + || [istarget "rs6000*-*-aix*"]) } {
> + set additional_flags ""
> + } else {
> + set additional_flags "additional_flags=-fpic"
> + }
> }
>
> if {[gdb_compile "${srcdir}/${subdir}/${libfile}1.c" "${objdir}/${subdir}/${libfile}1.o" object [list debug $additional_flags]] != ""} {
> @@ -93,7 +98,18 @@ if [istarget "hppa*-*-hpux*"] {
> gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
> }
> }
> -if {[gdb_compile "${objdir}/${subdir}/${testfile}.o ${objdir}/${subdir}/${libfile}1.sl ${objdir}/${subdir}/${libfile}2.sl" "${binfile}" executable {debug}] != ""} {
> +
> +if {$gcc_compiled} {
> + if { ([istarget "powerpc*-*-aix*"]
> + || [istarget "rs6000*-*-aix*"]) } {
> + set additional_flags "additional_flags=-L${objdir}/${subdir}"
> + } else {
> + set additional_flags ""
> + }
> +} else {
> + set additional_flags ""
> +}
> +if {[gdb_compile "${objdir}/${subdir}/${testfile}.o ${objdir}/${subdir}/${libfile}1.sl ${objdir}/${subdir}/${libfile}2.sl" "${binfile}" executable [list debug $additional_flags]] != ""} {
> gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
> }
>
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9