This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfa:rs6000] Don't use ->prev
> * rs6000-tdep.c (frame_get_saved_regs): Use rs6000_frame_chain()
>> instead of ->prev.
>
>
> I think that your patch is okay so long as you use FRAME_CHAIN()
> instead of rs6000_frame_chain(). Note that FRAME_CHAIN() may be set
> to something other than rs6000_frame_chain() depending upon the ABI / OS.
Ah, good catch, I've made the adjustment. Thanks.
> At the moment though, it doesn't really matter too much since the
> case -- signal handler trampolines -- that calling FRAME_CHAIN gets
> right is broken in frame_get_saved_regs() anyway. The Linux/PPC
> target works around this deficiency by interposing some code which
> computes the correct saved register locations for signal handler
> callers instead of calling the rs6000_* version which invokes
> rs6000_get_saved_register().
:-)
> 2002-04-14 Andrew Cagney <ac131313@redhat.com>
>
> * sparc-tdep.c (sparc_get_saved_register): Use get_prev_frame
> instead of ->prev.
> * z8k-tdep.c (z8k_frame_chain): Do not use ->prev.
> * s390-tdep.c (s390_frame_chain): Do not use ->prev.
> * rs6000-tdep.c (frame_get_saved_regs): Use rs6000_frame_chain()
> instead of ->prev.
>
I've checked this in.
Andrew