Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered(gdb_stderr,... in hpread.c

[Daniel Jacobowitz <drow at mvista dot com>]

On Wed, Apr 24, 2002 at 11:49:54AM -0700, Michael Snyder wrote:
> Pierre Muller wrote:
> > 
> > This is a second of the files that I listed in
> > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html
> > as still having direct uses of stderr.
> > 
> > I did not fix a 80 char overflow, because I didn't find a good way to do it:
> > If I try to align the string "Psymtab for %s already read in.  Shouldn't happen.\n"
> > with gdb_stderr, I still get an overflow, how show I indent the args then?
> > Should I break the string constant?
> 
> I've spent more time agonizing over such questions than I care to
> admit.  ;-)
> And I'm fairly strongly opinionated against greater-than-80-char lines.
> But I think when it comes to printf and string constants, we have to be
> a little loose about it.
> 
> If you wanted to do something really perverted, you could try this:
> 
>    fprintf_unfiltered (gdb_stderr, 
>                        "Psymtab for %s %s %s\n", 
> 			pst->filename, 
> 			"already read in. ",
> 			"Shouldn't happen.");

Please don't... if we someday actually use i18n, we'll just have to
kill all of these anyway.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer