This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] Multi-arch STARTUP_WITH_SHELL and START_INFERIOR_TRAPS_EXPECTED


> The following puts STARTUP_WITH_SHELL and START_INFERIOR_TRAPS_EXPECTED
> under the control of gdbarch.
> 
> Currently STARTUP_WITH_SHELL is not modified by any of the target configs,
> but START_INFERIOR_TRAPS_EXPECTED is modified by several.
> 
> This does not include changes to actually use the gdbarch'd versions.  Some
> of those will follow.
> 
> OK to commit?


> 	(START_INFERIOR_TRAPS_EXPECTED): New variable.  Defaults to 2.

``2'', hmm, yes!  I'm ok with this half.  Suggest also simplifying:

#ifdef START_INFERIOR_TRAPS_EXPECTED
   startup_inferior (START_INFERIOR_TRAPS_EXPECTED);
#else
   /* One trap to exec the shell, one to exec the program being 
debugged.  */
   startup_inferior (2);
#endif /* START_INFERIOR_TRAPS_EXPECTED */

as part of this commit.  Given this is inferior ``black magic'', I'd do 
one at a time.

(still thinking)
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]