This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] New bitflags type and eflags on i386/x86-64

From: Michal Ludvig <mludvig at suse dot cz>
To: Pierre Muller <muller at cerbere dot u-strasbg dot fr>
Cc: Daniel Jacobowitz <drow at mvista dot com>,gdb-patches at sources dot redhat dot com
Date: Mon, 29 Apr 2002 19:11:02 +0200
Subject: Re: [RFA] New bitflags type and eflags on i386/x86-64
Organization: SuSE CR
References: <3CC42916.9080001@suse.cz> <3CC42916.9080001@suse.cz> <4.2.0.58.20020429180717.020bacb0@ics.u-strasbg.fr>

Pierre Muller wrote:
> Given this info, I would support the creation of a TYPE_CODE_FLAGS 
> rather than trying to use pascal sets.
> Note that the code submitted does failm to write the flags if language is set to 
> pascal for instance... So this means that the p-valprint and
> maybe others (f-valprint or jv-valprint code should be adapted too).
> So maybe the best would be to move thiscode from c-valprint.c to valprint.c
> and simply call it for the different language-valprint.c sources.

Thanks for comments. I'll rework the patch and send again for approval 
with these changes. I was never a fan of "raping" type SET for this 
purpose.

> Last but not least, adding this  patch for i386-tdep source would allow to use
> this code also for normal  i386 cpus.

Sure, this bit is easy.

Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz

References:
- [RFA] New bitflags type and eflags on i386/x86-64
  - From: Michal Ludvig
- Re: [RFA] New bitflags type and eflags on i386/x86-64
  - From: Pierre Muller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]