This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Remote UDP support


On Sat, May 11, 2002 at 06:02:03PM -0400, Andrew Cagney wrote:
> >On Sat, May 11, 2002 at 03:13:02PM -0400, Andrew Cagney wrote:
> >
> >>>No.  I think it need to be in the users face.  I don't think GDB should 
> >
> >>>>silently let the user to use a broken mechanism.
> >
> >>>
> >>>
> >>>I really don't agree, but your call.  Could I at least persuade you
> >>>down to a one-line warning and no confirmation query?
> >
> >>
> >>Oh! All right then :-)
> >
> >
> >How's this look?  I wasn't quite sure what to put in the text of the
> >warning.  Also added one to the manual.
> 
> Problem is, its in the wrong place, and I suspect getting it into the 
> right place - remote.c - is tricky.
> 
> I think adding a FIXME hack to remote.c (search for serial_open) that 
> checks for ``udp:'' and then print a warning is the most pratical.

I don't understand.  Why hoist it up into remote.c, before each call to
serial_open?  That just descends through serial_open to call net_open
and the warning would arrive at the same position; the warning is
specific to ser-tcp, and seems to belong there.

Perhaps if you explain what you're trying to accomplish by having it
somewhere else.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]