Re: [RFA] Type cleanups

[Daniel Jacobowitz <drow at mvista dot com>]

On Sun, May 12, 2002 at 11:18:25PM -0400, Andrew Cagney wrote:
> >In order to fix gdb/277, I needed to move a lot of members of 'struct 
> >type'. This patch flushes out all (that I could find) direct accesses of 
> >these
> >members instead of through the proper macros.  It's possible that I missed
> >some; if so, the next patch will cause whichever files I missed to stop
> >compiling.  I'm pretty sure I got them all, though.  I also clean up the
> >only remaining references to 'sizeof (struct type)': dstread.c had a clone
> >of alloc_type, and hpread.c needed to call replace_type like the other
> >readers.
> >
> >This patch should have no effect.  On i386-linux, I get byte-for-byte
> >identical GDB binaries (all 5591185 bytes of it, debugging information
> >and all; no -g3 here).
> >
> >OK to commit?
> 
> Did you check all the cross targets build per MAINTAINERS?  From memory 
> sh-hms[bfd] and avr[need to look] don't build at present (well as of 
> ~2002-05-12-gmt).
> 
> If that has been checked, then yes ``obviously''.

A few don't build; none of them are my fault.  For the record:

	At least fr30-elf, mn10300-elf, and v850-elf have missing
dependencies off in sim/ land; they built with non-parallel make only.

	hppa1.1-hp-proelf wants dl.h and machine/save_state.h in
hppa-tdep.c, and was already marked broken.  The nice gawk segment
doesn't notice that...

	Several targets (i586-pc-msdosdjgpp, sparc-elf, sparc64-elf)
	failed with this message (also JB_SP for Sparc):

In file included from /usr/include/setjmp.h:30,
                 from ../../src-build/gdb/top.c:58:
/usr/include/bits/setjmp.h:31: warning: `JB_PC' redefined
tm.h:57: warning: this is the location of the previous definition
make[1]: *** [top.o] Error 1

	sh-hms failed with a reference to some new SHmedia code.

	x86-64 failed with:

libgdb.a(solib.o): In function `clear_solib':
/opt/src/gdb/crossbuild/obj.x86_64-linux-gnu/gdb/../../src-build/gdb/solib.c:742:
	undefined reference to `disable_breakpoints_in_shlibs'
libgdb.a(solib-svr4.o): In function `enable_break':
/opt/src/gdb/crossbuild/obj.x86_64-linux-gnu/gdb/../../src-build/gdb/solib-svr4.c:856:
	undefined reference to `remove_solib_event_breakpoints'
/opt/src/gdb/crossbuild/obj.x86_64-linux-gnu/gdb/../../src-build/gdb/solib-svr4.c:983:
	undefined reference to `create_solib_event_breakpoint'

Is x86-64 really "maintenance only"?


Anyway, committed.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer