This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Update D10V generic_dummy calls


Michael Snyder wrote:
> 
> Michael Snyder wrote:
> >
> > Andrew Cagney wrote:
> > >
> > > > 2002-05-22  Michael Snyder  <msnyder@redhat.com>
> > > >
> > > >       * d10v-tdep.c: Change a few macros to enums for ease of debugging.
> > > >       (d10v_frame_chain_valid): Add PC_IN_CALL_DUMMY clause.
> > > >       (d10v_frame_saved_pc): Add PC_IN_CALL_DUMMY clause.
> > > >       (d10v_frame_chain): Bail immediately if PC_IN_CALL_DUMMY.
> > > >       Don't bail if return_pc is PC_IN_CALL_DUMMY.
> > > >       Add a temp variable to save a call (and a memory read).
> > > >       (d10v_init_extra_frame_info): Get fi->pc from callee's return_pc
> > > >       if possible (so that PC_IN_CALL_DUMMY will work).
> > > >
> > >
> > > Michael,
> > >
> > > This patch:
> > >
> > > > *************** d10v_gdbarch_init (struct gdbarch_info i
> > > > *** 1486,1492 ****
> > > >     set_gdbarch_register_byte (gdbarch, d10v_register_byte);
> > > >     set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size);
> > > >     set_gdbarch_max_register_raw_size (gdbarch, 8);
> > > > !   set_gdbarch_register_virtual_size (gdbarch, generic_register_size);
> > > >     set_gdbarch_max_register_virtual_size (gdbarch, 8);
> > > >     set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type);
> > > >
> > > > --- 1525,1531 ----
> > > >     set_gdbarch_register_byte (gdbarch, d10v_register_byte);
> > > >     set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size);
> > > >     set_gdbarch_max_register_raw_size (gdbarch, 8);
> > > > !   set_gdbarch_register_virtual_size (gdbarch, generic_register_virtual_size);
> > > >     set_gdbarch_max_register_virtual_size (gdbarch, 8);
> > > >     set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type);
> > > >
> > >
> > > Wasn't mentioned in the change log and breaks d10v builds :-(
> >
> > Eh?  I don't remember doing that...
> >
> > Oh!  My source tree isn't up to date!
> > Sorry about that -- please withdraw this patch and I'll re-submit.
> > Good thing I hadn't gotten around to checking it in yet...
> 
> Wait a minute -- I did check it in.  But evidently it was
> not in sync.  I can't understand how this could have happened.

Argh.  Well, Andrew, I've verified that you succeeded in straightening
out my mess.  Thank you.  The file is as it should be now.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]