This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] Generic OS ABI handling for PowerPC

On May 28,  5:26pm, Jason R Thorpe wrote:

> Ok, new patch.  Moves the ppc_sysv stuff into new ppc-sysv-tdep.c,
> and updates the various .mt files.  I also touched up some dependency
> lists in Makefile.in.
> 
> OK to commit?

Sure, go ahead.

The only nit I have is with parts of your ChangeLog entry.  Entries like
this one...

> 	* ppc-linux-tdep.c (_initialize_ppc_linux_tdep,
> 	ppc_linux_init_abi): New functions.
> 	(ppc_sysv_abi_broken_use_struct_convention,
> 	ppc_sysv_abi_use_struct_convention,
> 	ppc_sysv_abi_push_arguments): Move to...

...should be formatted as follows:

	* ppc-linux-tdep.c (_initialize_ppc_linux_tdep)
	(ppc_linux_init_abi): New functions.
	(ppc_sysv_abi_broken_use_struct_convention)
	(ppc_sysv_abi_use_struct_convention)
	(ppc_sysv_abi_push_arguments): Move to...

(Actually, I prefer the way you did it, but I've been told that it's
incorrect.)

Kevin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]