This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Proposed gdb patch


> Date: Thu, 6 Jun 2002 18:10:27 +0100
> From: "G. Helffrich" <george@gly.bris.ac.uk>
> 
>      Following previous comments, here is an updated version of the
> proposed patch to gdb 5.1.1 (28 May 2002) that adds functionality to the gdb
> command language.  It implements the "edit" command featured in the Sun and
> SGI dbx, which invokes your favorite file editor on the active line of the
> program being debugged.

Thanks.

> +   add_com ("edit", class_files, edit_command,
> +            concat ("Edit specified file or function.\n\
> + With no argument, edits file containing most recent line listed.\n\
> + ", "\
> + Editing targets can be specified in these ways:\n\
> +   FILE:LINENUM, to edit at that line in that file,\n\
> +   FUNCTION, to edit at the beginning of that function,\n\
> +   FILE:FUNCTION, to distinguish among like-named static functions.\n\
> +   *ADDRESS, to edit at the line containing that address.\n\
> + Uses EDITOR environment variable contents as editor (or ex as default).",NULL));

I'd prefer that this command used the location_completer as its
completion function, since the arguments it accepts are source code
locations similar to the "break" command.

> Index: gdb-5.1.1/src/gdb/doc/gdb.texinfo

The docs changes are approved, but please fix the following minor
problem:

> + @node Edit
> + @section Editing source files

Please add here an index entry, for example:

  @cindex editing source files


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]