This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
BTW, attr_format was only added to error() (one of GDBs most important functions) a month or so ago. While the attribute has been around for a while, it is relativly new for GDB.At 02:49 21/06/2002 , Andrew Cagney a écrit:+/* Function used to avoid direct calls to fprintf + in the code generated by the bison parser. */ + +extern void parser_fprintf (FILE *, const char *, ...);Hmm, wonder if there is any benefit in adding ATTR_FORMAT(printf, 2, 3) to the declaration?I didn't even know this modifier :(
My only reservation was that bison/yacc could turn out to generate badly formatted printf statements. However, if that is happening then we need to know anyway.But it does look appropriate indeed.
Anyway, yes,Does this mean I can apply the patch?
Yes, either way. Andrew (I'm just happy to see these fprintf() slowly disappearing :-)
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |