This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
RE: [RFA/RFC] blockframe.c Fix errorneous addr check
- From: Andrew Volkov <Andrew dot Volkov at transas dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, jimb at redhat dot com,ezannoni at redhat dot com
- Date: Thu, 27 Jun 2002 22:58:23 +0400
- Subject: RE: [RFA/RFC] blockframe.c Fix errorneous addr check
>
>On Jun 27, 10:08pm, Andrew Volkov wrote:
>
>> Daniel you're right, this bug in coffread.c(complete_symtab)
>function,
>> rather, in invalid calculating of current_source_end_addr:
>>
>> current_source_end_addr = start_addr + size;
>>
>> but must be:
>>
>> current_source_end_addr = start_addr + size + <addr sizeof>;
>>
>> As I understand, since machine address size is not known at
>time of parsing
>> coff file, then we have big trouble :(.
>
>Could you explain why you need to add in the size of an address?
It's not necessarily must be addr sizeof, it may be 1, but, I think,
will be better, if current_source_end_addr will contain correct
value for target.
>
>Assuming it is needed, won't TARGET_PTR_BIT / TARGET_CHAR_BIT
>provide the
>correct size?
>
>Kevin
>
Sorry, I forget about this macros :)
Andrey