This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA/RFC] blockframe.c Fix errorneous addr check


>
>On Jun 27, 10:08pm, Andrew Volkov wrote:
>
>> Daniel you're right, this bug in coffread.c(complete_symtab) 
>function,
>> rather, in invalid calculating of current_source_end_addr:
>> 
>> 	current_source_end_addr = start_addr + size;
>> 
>> but must be:
>> 
>> 	current_source_end_addr = start_addr + size + <addr sizeof>;
>> 
>> As I understand, since machine address size is not known at 
>time of parsing 
>> coff file, then we have big trouble :(.
>
>Could you explain why you need to add in the size of an address?

It's not necessarily must be addr sizeof, it may be 1, but, I think,
will be better, if current_source_end_addr will contain correct 
value for target.

>
>Assuming it is needed, won't TARGET_PTR_BIT / TARGET_CHAR_BIT 
>provide the
>correct size?
>
>Kevin
>
Sorry, I forget about this macros :)

Andrey


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]