This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame()

From: Andrew Cagney <ac131313 at ges dot redhat dot com>
To: Mark Kettenis <kettenis at chello dot nl>
Cc: gdb-patches at sources dot redhat dot com
Date: Mon, 08 Jul 2002 14:36:35 -0400
Subject: Re: [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame()
References: <200207072144.g67LioR02326@walton.kettenis.dyndns.org>

Using alloca() here is pretty obvious.  I discussed the other fix with
Michael Ludvig.

Checked in.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* dwarf2cfi.c (cfi_pop_frame): Use alloca() for regbuf.
	Don't call get_current_frame().

Heads up,

I think the write_register_bytes() call should be replaced by regcache_register_write(current_regcache, ). This is new code so it doesn't need to go through any of that nasty write_register_bytes() stuff.

Andrew

Follow-Ups:
- Re: [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame()
  - From: Richard Earnshaw

References:
- [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame()
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]