This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFC: initial TLS patch
Andrew Cagney <ac131313@ges.redhat.com> writes:
> > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE);
> >
> >> Tipo OBJFILE -> objfile.
> > It was capitalized to match the comment above:
> > + /* Return the so_list entry whose object file is OBJFILE. */
> > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE);
> > + But the rest of GDB doesn't do that, so I'll change this.
>
> Just FYI, from the coding doco:
>
> > The comment on a function is much clearer if you use the argument
> > names to speak about the argument values. The variable name itself
> > should be lower case, but write it in upper case when you are
> > speaking about the value rather than the variable itself. Thus, "the
> > inode number NODE_NUM" rather than "an inode".
Chapter and verse, indeed. Already fixed.