This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: dwarf2expr.[ch]
- From: Andrew Cagney <ac131313 at ges dot redhat dot com>
- To: Daniel Berlin <dberlin at dberlin dot org>, jimb at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 08 Jul 2002 23:15:40 -0400
- Subject: Re: [RFA]: dwarf2expr.[ch]
- References: <Pine.LNX.4.44.0207081941190.31676-100000@dberlin.org>
Daniel,
Just a reminder. As a GNU developer, you're expected to submit patches
that meet the GNU coding standard. This is important as it saves on
significiant run-around time spent by both yourself and the reviewer.
I guess you ment, work-in-progress.
A quick glance at this patch reveals:
Index: dwarf2expr.c
===================================================================
RCS file: dwarf2expr.c
diff -N dwarf2expr.c
*** /dev/null 1 Jan 1970 00:00:00 -0000
--- dwarf2expr.c 8 Jul 2002 23:41:18 -0000
***************
*** 0 ****
--- 1,479 ----
No copyright notice.
+
+ #include "defs.h"
+ #include "symtab.h"
+ #include "gdbtypes.h"
+ #include "elf/dwarf2.h"
+ #include "dwarf2expr.h"
Incorrectly indented function prototype (one of many). Should be ISO C.
+ struct dwarf_expr_context * new_dwarf_expr_context()
+ {
+ struct dwarf_expr_context *retval;
+ retval = xcalloc (1, sizeof (struct dwarf_expr_context));
+ return retval;
+ }
enjoy,
Andrew