This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] gdbreplay.c
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: David O'Brien <obrien at FreeBSD dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 9 Jul 2002 13:33:22 -0400
- Subject: Re: [PATCH] gdbreplay.c
- References: <20020709172541.GA26506@dragon.nuxi.com>
On Tue, Jul 09, 2002 at 10:25:41AM -0700, David O'Brien wrote:
> I'd like to commit this change.
>
> This seems more proper for the includes includes, and the staticization
> is needed to quiet GCC at high warning levels.
I'm not sure if you're asking or telling since it sounds like you've
committed the matching patch to the 5.2 branch?
In any case, no objection, so please commit it. But when does GCC warn
about a function not being static? Doesn't make a lot of sense to me;
it doesn't know that you won't link with -Bsymbolic and use DSO's, for
instance.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer