This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] Symbol hashing (for the last time?)


Daniel Jacobowitz writes:
 > Here's a patch from last October, dusted off and merged to the current
 > sources.  The only substantial changes were some fixes for ada-lang.c,
 > merged after I wrote the original patch.  I've verified no regressions
 > on i386-linux for GCC (2.95,3.0.4,3.1)/(stabs,dwarf2).
 >

On my plate as well. I think I reviewed a few precursor patches to
this. I have to reread the old threads.

Of course if anybody else has comments, please feel free.

Elena

 
 > This converts the normal symbol table lookups into hash tables.  A few
 > sorts of symbol tables aren't hashed: those produced by mdebugread.c
 > and dstread.c, because they build symbol tables in lots of ad-hoc code,
 > and symbol tables which are actually the arguments to a function
 > (because order matters, or at least comments suggest so).  A next step
 > will be to convert mdebugread.c, delete dstread.c (it's marked for an
 > upcoming obsoletion, isn't it?), and then delete all the complicated
 > binary search code since the only remaining unhashed symtabs will be
 > argument lists, which are small.
 > 
 > This should help performance a bit on large programs.  Ok to commit? 
 > Anyone see any problems with it?
 > 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]