This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)


Kevin Buettner writes:
 > On Jul 16,  4:30pm, Joel Brobecker wrote:
 > 
 > > I can do the following, all within a short period:
 > >   - remove the braces (without indentation change)
 > >   - commit
 > >   - run gdb_indent.sh
 > >   - commit
 > >   
 > > That way, we have one commit which contains a code change, but the diff
 > > is readable. The second diff may be unreadable, but will contain no code
 > > change.
 > > 
 > > Should I go ahead?
 > 
 > Sounds okay to me...
 > 
 > (I'd say go ahead provided you get a couple more "yes" votes and no
 > objections.)

It had my vote. I would just go ahead (post the diffs, though).

Elena


 > 
 > Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]