RE: [RFA] sim-h8300.h new file

[Elena Zannoni <ezannoni at redhat dot com>]

Andrew Volkov writes:
 > Committed
 > 
 > Andrey

Ahem, this hadn't been approved.  Could you please change the file so
that it follows the convention used for other sims?  Look at
sim-arm.h, for instance. You should call the enum values
SIM_H8300_R0_REGNUM, etc. Don't need to distinguish the reg names
based on the mode. (you can add comments though)

thanks
Elena


 > 
 > >-----Original Message-----
 > >From: Andrew Volkov [mailto:Andrew.Volkov@transas.com]
 > >Sent: Monday, July 22, 2002 7:09 PM
 > >To: Elena Zannoni
 > >Cc: gdb-patches@sources.redhat.com
 > >Subject: RE: [RFA] sim-h8300.h new file
 > >
 > >
 > >Hi Elena,
 > >
 > >Are you have this in view ?
 > >
 > >Andrey
 > >
 > >Index: sim-h8300.h
 > >===================================================================
 > >RCS file: sim-h8300.h
 > >diff -N sim-h8300.h
 > >--- /dev/null	1 Jan 1970 00:00:00 -0000
 > >+++ sim-h8300.h	22 Jul 2002 15:06:51 -0000
 > >@@ -0,0 +1,75 @@
 > >+/* This file defines the interface between the sh simulator and gdb.
 > >+   Copyright (C) 2002 Free Software Foundation, Inc.
 > >+
 > >+This file is part of GDB.
 > >+
 > >+This program is free software; you can redistribute it and/or modify
 > >+it under the terms of the GNU General Public License as published by
 > >+the Free Software Foundation; either version 2 of the License, or
 > >+(at your option) any later version.
 > >+
 > >+This program is distributed in the hope that it will be useful,
 > >+but WITHOUT ANY WARRANTY; without even the implied warranty of
 > >+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 > >+GNU General Public License for more details.
 > >+
 > >+You should have received a copy of the GNU General Public License
 > >+along with this program; if not, write to the Free Software
 > >+Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 
 > >02111-1307, USA.
 > >*/
 > >+
 > >+#if !defined (SIM_H8300_H)
 > >+#define SIM_H8300_H
 > >+
 > >+#ifdef __cplusplus
 > >+extern "C" { //}
 > >+#endif
 > >+  
 > >+/* The simulator makes use of the following register information. */ 
 > >+  
 > >+/* Registers common to all the H8 variants. */
 > >+  enum sim_h8300_regs
 > >+  {
 > >+    H8300_R0_REGNUM = 0,
 > >+    H8300_R1_REGNUM,
 > >+    H8300_R2_REGNUM,
 > >+    H8300_R3_REGNUM,
 > >+    H8300_R4_REGNUM,
 > >+    H8300_R5_REGNUM,
 > >+    H8300_R6_REGNUM,
 > >+    H8300_R7_REGNUM,
 > >+
 > >+    H8300_PC_REGNUM,	/* Contains program counter */
 > >+    H8300_CCR_REGNUM,	/* Contains processor status */
 > >+
 > >+    H8300_S_EXR_REGNUM, /* Contains extended processor status */
 > >+    H8300_S_MACL_REGNUM,/* Lower part of MAC register */
 > >+    H8300_S_MACH_REGNUM,/* High part of MAC register */
 > >+
 > >+    H8300_SIM_CYCLE_REGNUM,
 > >+    H8300_SIM_INST_REGNUM,
 > >+    H8300_SIM_TICK_REGNUM
 > >+  };
 > >+
 > >+  enum
 > >+  {
 > >+    ARG_FIRST_REGNUM = H8300_R0_REGNUM,	/* first reg in 
 > >which an arg
 > >
 > >+					               may be passed */
 > >+    ARG_LAST_REGNUM = H8300_R3_REGNUM,	/* last  reg in 
 > >which an arg 
 > >+ 					               may be passed */
 > >+    H8300_FP_REGNUM = H8300_R6_REGNUM,	/* Contain 
 > >address of executing 
 > >+					   		   
 > >stack frame */
 > >+    H8300_SP_REGNUM = H8300_R7_REGNUM	/* Contains address of 
 > >top of stack
 > >*/
 > >+  };
 > >+
 > >+  enum
 > >+  {
 > >+    H8300_NUM_COMMON_REGS = 10,
 > >+    H8300_S_NUM_REGS = 13,
 > >+    H8300_SIM_NUM_REGS = 16
 > >+  };
 > >+
 > >+#ifdef __cplusplus
 > >+}
 > >+#endif
 > >+ 
 > >+#endif				/* SIM_H8300_H */
 > >