This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit

From: Michael Snyder <msnyder at redhat dot com>
To: Kevin Buettner <kevinb at redhat dot com>
Cc: ac131313 at redhat dot com, gdb-patches at sources dot redhat dot com
Date: Wed, 31 Jul 2002 16:21:15 -0700
Subject: Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit
Organization: Red Hat, Inc.
References: <1020731210452.ZM23445@localhost.localdomain> <3D486843.8007D610@redhat.com> <1020731232203.ZM24308@localhost.localdomain>

Kevin Buettner wrote:
> 
> On Jul 31,  3:44pm, Michael Snyder wrote:
> 
> > >         * mips-tdep.c (mips_push_arguments): Don't assume that
> > >         ``MIPS_SAVED_REGSIZE < 8'' means that the o64 abi is in use.
> > >         Instead, test for it explicitly.
> >
> > Kevin,
> >
> > This change makes things worse for N32.  I haven't tested
> > N64 yet.  I think we're gonna have to look at these lines
> > from the perspective of all 3 (6) abis.
> 
> Okay, this patch is withdrawn while I retest...
> 
> To save some time, can you tell me which N32 regressions you see?

Buncha failures in structs.exp.
If you have a look at the tweak that I sent, it might be the thing.

References:
- [RFA] mips_push_arguments(): Make O64 ABI test explicit
  - From: Kevin Buettner
- Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit
  - From: Michael Snyder
- Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit
  - From: Kevin Buettner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]