This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] mips-n32 use_struct_convention


Andrew Cagney wrote:
> 
> > *************** show_mask_address (char *cmd, int from_t
> > *** 561,570 ****
> >   int
> >   mips_use_struct_convention (int gcc_p, struct type *type)
> >   {
> > !   if (MIPS_EABI)
> >       return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE);
> >     else
> > !     return 1;                       /* Structures are returned by ref in extra arg0 */
> >   }
> >
> >   /* Tell if the program counter value in MEMADDR is in a MIPS16 function.  */
> > --- 570,579 ----
> >   int
> >   mips_use_struct_convention (int gcc_p, struct type *type)
> >   {
> > !   if (MIPS_EABI || MIPS_NEWABI)
> >       return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE);
> >     else
> > !     return 1;       /* Old ABI: structures are returned by ref in extra arg0 */
> >   }
> >
> 
> Rather than doing this, can you please create two functions --- one for
> each case --- and then update mips_gdbarch_init() accordingly.


OK.  Patch withdrawn pending rewrite.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]