This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa/testsuite] One pass/fail per expect list


On Aug 5, 11:56pm, Andrew Cagney wrote:

> >> The attached tweaks gdb_expect_list{} so that it only prints one pass / 
> >> fail / ... message for the testcase.
> >> 
> >> What are peoples thoughts on this change and if positive, is the patch ok?
> > 
> > Now that it's in and I've had a chance to use it, the only part that
> > I don't like is:
> > 
> > 
> >> -		unresolved "${test}, pattern ${index} + sentinel"
> >> +		# unresolved "${test}, pattern ${index} + sentinel"
> > 
> > 
> > I found it useful to see the (potentially long list of) UNRESOLVED
> > messages after the FAIL so that I knew how many other parts of the
> > test hadn't been checked.
> 
> 
> What about including the total number of patterns in the test result 
> message vis:
> 	.... (pattern N of NN)

In the FAIL message, right?  If so, I think that'd be okay.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]