This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa:i386] Add mmx registers
- From: Mark Kettenis <kettenis at chello dot nl>
- To: Andrew Cagney <ac131313 at ges dot redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 12 Aug 2002 20:09:53 +0200
- Subject: Re: [rfa:i386] Add mmx registers
- References: <3D55A89F.9040300@ges.redhat.com>
Andrew Cagney <ac131313@ges.redhat.com> writes:
> Hello,
>
> This adds mmx registers to the i386.
Great, a few nits though :-(
* Please rename is_mmx_regnum() to mmx_regnum_p().
* Please rename nr_mmx_regs to mmx_num_regs.
* Why do you use regcache_raw_read_as_address() in
mmx_regnum_to_fp_regnum? Looks misleading to me...
Mark