This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfc] regcache_raw_read_as_address() -> regcache_cooked_read_as_ulongest()
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Andrew Cagney <ac131313 at ges dot redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, Mark Kettenis <kettenis at science dot uva dot nl>
- Date: Mon, 12 Aug 2002 16:12:18 -0400
- Subject: Re: [patch/rfc] regcache_raw_read_as_address() -> regcache_cooked_read_as_ulongest()
- References: <3D5811CA.2070205@ges.redhat.com>
On Mon, Aug 12, 2002 at 03:51:38PM -0400, Andrew Cagney wrote:
> Hello,
>
> This patch replaces the function regcache_raw_read_as_address() with the
> pair:
> regcache_cooked_read_as_longest()
> regcache_cooked_read_as_ulongest()
> The two calls to the old ..as_address() being replaced with the ulongest
> version.
>
> I think the change is ok (i386 shows no regressions, the mips doesn't
> use this code :-). I'm just wondering about the names. Perhaps:
> regcache_cooked_read_signed() & regcache_cooked_read_unsigned()?
>
> thoughts?
Hmm, I like _read_signed and _read_unsigned... the _as_longest bit is
implicit.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer