Re: [PATCH] Remove some write_register_bytes occurences from i386-tdep.c

[Andrew Cagney <ac131313 at ges dot redhat dot com>]

> This replaces two write_register_bytes invocations with
> write_register_gen.  The remaining occurences are in principle
> legitimate calls to write_register_bytes, since the intent *is* a
> partial update of a register.  Of course I can "open code" these calls
> if that's desirable.
>
> Checked in.
>
> Mark
>
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 	* i386-tdep.c (i386_do_pop_frame, i386_store_return_value): Call
> 	write_register_gen instead of write_register_bytes.
Hmm, [change-request bug report] pop_frame and store_return_value are 
going to need the same treatment as was given to extract_return_value() 
-- add a regcache parameter so that the registers can be directly 
written to the register cache.  This reduces the reliance on a single 
global register cache.

As for write_register_bytes() can it be avoided?  I've just posted 
``regcache_cooked_write_with_offset_hack().  But I don't think that hack 
is right here.  Perhaphs a single register read - modify - write 
function is needed?

Andrew


> Index: i386-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.81
> diff -u -p -r1.81 i386-tdep.c
> --- i386-tdep.c 17 Aug 2002 11:39:38 -0000 1.81
> +++ i386-tdep.c 18 Aug 2002 17:15:10 -0000
> @@ -833,8 +833,7 @@ i386_do_pop_frame (struct frame_info *fr
>        if (addr)
>  	{
>  	  read_memory (addr, regbuf, REGISTER_RAW_SIZE (regnum));
> -	  write_register_bytes (REGISTER_BYTE (regnum), regbuf,
> -				REGISTER_RAW_SIZE (regnum));
> +	  write_register_gen (regnum, regbuf);
>  	}
>      }
>    write_register (FP_REGNUM, read_memory_integer (fp, 4));
> @@ -1003,8 +1002,7 @@ i386_store_return_value (struct type *ty
>  	 not exactly how it would happen on the target itself, but
>  	 it is the best we can do.  */
>        convert_typed_floating (valbuf, type, buf, builtin_type_i387_ext);
> -      write_register_bytes (REGISTER_BYTE (FP0_REGNUM), buf,
> -			    FPU_REG_RAW_SIZE);
> +      write_register_gen (FP0_REGNUM, buf);
>  
>        /* Set the top of the floating-point register stack to 7.  The
>           actual value doesn't really matter, but 7 is what a normal